Enable combined disk cache for grpc caching protocol.#10233
Closed
buchgr wants to merge 1 commit intobazelbuild:masterfrom
Closed
Enable combined disk cache for grpc caching protocol.#10233buchgr wants to merge 1 commit intobazelbuild:masterfrom
buchgr wants to merge 1 commit intobazelbuild:masterfrom
Conversation
This change enables the combined disk cache for the gRPC protocol too. $ bazel build src:bazel --disk_cache=/path/to/dir --remote_cache=grpcs://... It does not yet also enable it for remote execution as this will need a bit more work. In particular it will require some refactorings around RemoteCacheClient#findMissingBlobs as when used with remote execution findMissingBlobs() should only check the remote cache and not the local disk cache. Else, it could happen that an input file is missing from the local cache but not from the remote cache in which case Bazel would attempt to upload the file again. RELNOTES: The --disk_cache flag can now also be used together with the gRPC remote cache.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change enables the combined disk cache for the gRPC
protocol too.
$ bazel build src:bazel --disk_cache=/path/to/dir
--remote_cache=grpcs://...
It does not yet also enable it for remote execution as
this will need a bit more work. In particular it will
require some refactorings around RemoteCacheClient#findMissingBlobs
as when used with remote execution findMissingBlobs() should
only check the remote cache and not the local disk cache. Else,
it could happen that an input file is missing from the local
cache but not from the remote cache in which case Bazel would
attempt to upload the file again.
RELNOTES: The --disk_cache flag can now also be used together
with the gRPC remote cache.