-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Closed
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Rules-APIAPI for writing rules/aspects: providers, runfiles, actions, artifactsAPI for writing rules/aspects: providers, runfiles, actions, artifactstype: buguntriaged
Description
A user writing a new experimental rule ran into this issue, that it seemed that enviornment variables were not being correctly set on an action created with ctx.action.run_shell, when use_default_shell_env=True. We should probably throw some sort of error when a user tries to specify both env and use_default_shell_env=True, to avoid this confusion in the future.
jiridanek and NathanBWaters
Metadata
Metadata
Assignees
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Rules-APIAPI for writing rules/aspects: providers, runfiles, actions, artifactsAPI for writing rules/aspects: providers, runfiles, actions, artifactstype: buguntriaged