-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Skip UTF-8 BOM sequence when reading BUILD & .bzl files. #4551
Copy link
Copy link
Closed as not planned
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)staleIssues or PRs that are stale (no activity for 30 days)Issues or PRs that are stale (no activity for 30 days)team-Starlark-IntegrationIssues involving Bazel's integration with Starlark, excluding builtin symbolsIssues involving Bazel's integration with Starlark, excluding builtin symbolstype: feature request
Milestone
Description
Description of the problem / feature request:
Unfortunately bazel does not support UTF-8 BOM sequences in BUILD files.
Output of bazel build ...:
C:\Users\Chebotarev_V\Documents\bazel-issues\utf-8-bom-support>bazel build ...
........................
ERROR: C:/users/chebotarev_v/documents/bazel-issues/utf-8-bom-support/BUILD:1:1: invalid character: 'я'
ERROR: C:/users/chebotarev_v/documents/bazel-issues/utf-8-bom-support/BUILD:1:2: invalid character: '╗'
ERROR: C:/users/chebotarev_v/documents/bazel-issues/utf-8-bom-support/BUILD:1:3: invalid character: '┐'
ERROR: package contains errors:
ERROR: error loading package '': Package '' contains errors
INFO: Elapsed time: 5.202s
FAILED: Build did NOT complete successfully (1 packages loaded)
Please find an example in my repository:
https://github.com/excitoon/bazel-issues/tree/master/utf-8-bom-support
Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.
bazel build ...
What operating system are you running Bazel on?
Windows 10 x64
What's the output of bazel info release?
Build label: 0.9.0
Build target: bazel-out/x64_windows-opt/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Tue Dec 19 09:32:04 2017 (1513675924)
Build timestamp: 1513675924
Build timestamp as int: 1513675924
Have you found anything relevant by searching the web?
Nothing.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)staleIssues or PRs that are stale (no activity for 30 days)Issues or PRs that are stale (no activity for 30 days)team-Starlark-IntegrationIssues involving Bazel's integration with Starlark, excluding builtin symbolsIssues involving Bazel's integration with Starlark, excluding builtin symbolstype: feature request