Skip to content

http.bzl : all_urls is given the remote_patch URL which is surely a mistake. #22201

@fzakaria

Description

@fzakaria

Description of the bug:

all_urls includes the remote_patch URL key for http_archive.
This value is passed to downlolad_and_extract which is a bug.

This means that if the original URLs for the http_archive fail, it will treat the remote_patch as the URL for the archive itself.

Please see:

download_info = ctx.download_and_extract(

This came up during my writing of PR #22155

CC @Wyverald

Metadata

Metadata

Assignees

Labels

P1I'll work on this now. (Assignee required)team-ExternalDepsExternal dependency handling, remote repositiories, WORKSPACE file.type: bug

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions