-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Closed
Labels
P1I'll work on this now. (Assignee required)I'll work on this now. (Assignee required)team-ExternalDepsExternal dependency handling, remote repositiories, WORKSPACE file.External dependency handling, remote repositiories, WORKSPACE file.type: bug
Description
Description of the bug:
all_urls includes the remote_patch URL key for http_archive.
This value is passed to downlolad_and_extract which is a bug.
This means that if the original URLs for the http_archive fail, it will treat the remote_patch as the URL for the archive itself.
Please see:
bazel/tools/build_defs/repo/http.bzl
Line 141 in 0e7c0fb
| download_info = ctx.download_and_extract( |
This came up during my writing of PR #22155
CC @Wyverald
Metadata
Metadata
Assignees
Labels
P1I'll work on this now. (Assignee required)I'll work on this now. (Assignee required)team-ExternalDepsExternal dependency handling, remote repositiories, WORKSPACE file.External dependency handling, remote repositiories, WORKSPACE file.type: bug