Skip to content

Enhance "actuallyCompleteAction" algorithm for better build performance #18614

@chiragramani

Description

@chiragramani

Description of the bug:

actuallyCompleteAction adversely affects our build performance and has been a constant bottleneck.

As we analyze the step named 'Bundling, processing and signing App`, it is primarily composed of 2 parts.

  1. BundleTreeApp: 272ms
  2. actuallyCompleteAction: 12s 825ms

We can see that almost 100% of the time of this step is the overhead introduced by actuallyCompleteAction.
Screenshot 2023-06-07 at 6 51 37 PM

This happens on every build and comes with a significantly high wait time cost as artifacts are huge. Any improvements here would be super helpful.

Related threads: #18194, #17009, #10702

Below is a repro that demonstrates the bottleneck.

Repro on macOS:

bazel build //:App

test_bundling2.zip

What's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Repro on macOS:

bazel build //:App

test_bundling2.zip

Which operating system are you running Bazel on?

macOS

What is the output of bazel info release?

release 6.2.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse master; git rev-parse HEAD ?

No response

Is this a regression? If yes, please try to identify the Bazel commit where the bug was introduced.

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2We'll consider working on this in future. (Assignee optional)team-Remote-ExecIssues and PRs for the Execution (Remote) teamtype: bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions