-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Open
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)team-Configurabilityplatforms, toolchains, cquery, select(), config transitionsplatforms, toolchains, cquery, select(), config transitionsteam-DocumentationDocumentation improvements that cannot be directly linked to other team labelsDocumentation improvements that cannot be directly linked to other team labelstype: documentation (cleanup)
Description
Goal: Deprecate copy_from_rule parameter from exec_groups.
Reason: Simplification of the API since it’s not widely spread.
In case you’re using it and you have a breakage:
- Add toolchain types manually from the rule to the exec_group
- Add constraints manually from the rule to the exec_group
Example:
custom_rule = rule(
_impl,
exec_groups = {
“test_group”: exec_group(
copy_from_rule = True,
),
},
toolchains = [“//tools/jdk:toolchain_type”, “//tools/cpp:toolchain_type”],
exec_compatible_with = “//third_party/bazel_platforms/os:linux”,
)
Should become:
custom_rule = rule(
_impl,
exec_groups = {
“test_group”: exec_group(
toolchains = [“//tools/jdk:toolchain_type”, “//tools/cpp:toolchain_type”],
exec_compatible_with = “//third_party/bazel_platforms/os:linux”,
),
},
toolchains = [“//tools/jdk:toolchain_type”, “//tools/cpp:toolchain_type”],
exec_compatible_with = “//third_party/bazel_platforms/os:linux”,
)
Metadata
Metadata
Assignees
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)team-Configurabilityplatforms, toolchains, cquery, select(), config transitionsplatforms, toolchains, cquery, select(), config transitionsteam-DocumentationDocumentation improvements that cannot be directly linked to other team labelsDocumentation improvements that cannot be directly linked to other team labelstype: documentation (cleanup)