Skip to content

Document behavior of custom env and env_inherit attributes in Starlark rules #12758

@brandjon

Description

@brandjon

eb5cdcb added built-in env and env_inherit attributes that control the environment of an executable target in a blaze run invocation. It's still possible to define these attributes in custom rules. If that happens, and if they are of the right type (strict dict and string list), they will be interpreted specially, probably contrary to the rule author's intent.

The clearest thing to do would be to prohibit these attribute names in Starlark rules now that they have special meaning. But that's a breaking change and possibly overkill. We should at least document this unintended interaction.

+@katre as reviewer of that change. (label team-Starlark, but really team-BuildLanguage, which we haven't created yet.)

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions