-
Notifications
You must be signed in to change notification settings - Fork 4.4k
target label paths with non-latin1 characters have inconsistent starlark semantics. #11602
Copy link
Copy link
Closed
Closed
Copy link
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Starlark-IntegrationIssues involving Bazel's integration with Starlark, excluding builtin symbolsIssues involving Bazel's integration with Starlark, excluding builtin symbolstype: bug
Milestone
Description
If we have a source file with a non Latin1 character in the file name (e.g. λ.file)
- and it is referenced in a glob(), let's say to attribute srcs (of type label_list)
- and you evaluate attr.srcs[n].label.name
- the length of the string is 7 on linux and macos
- but it is 6 on windows
Hilarity ensues while trying to figure out how to write these strings as part of an action.
Discovered while trying to fix #10174 More details to follow.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P4This is either out of scope or we don't have bandwidth to review a PR. (No assignee)This is either out of scope or we don't have bandwidth to review a PR. (No assignee)team-Starlark-IntegrationIssues involving Bazel's integration with Starlark, excluding builtin symbolsIssues involving Bazel's integration with Starlark, excluding builtin symbolstype: bug