Remote: Use shutdownNow() instead of shutdown() in ChannelConnection#close() as a workaround to a gRPC bug.

coeuvre · copybara-github · commit f6e1074b09eb · 2021-04-08T19:20:24.000-07:00
There is a bug (b/183340374) in gRPC that client doesn't try to close connections with shutdown() if the channel received GO_AWAY frames. Using shutdownNow() here as a workaround.

PiperOrigin-RevId: 367552792
diff --git a/src/main/java/com/google/devtools/build/lib/remote/grpc/ChannelConnectionFactory.java b/src/main/java/com/google/devtools/build/lib/remote/grpc/ChannelConnectionFactory.java
@@ -46,7 +46,10 @@ public <ReqT, RespT> ClientCall<ReqT, RespT> call(
 
     @Override
     public void close() throws IOException {
-      channel.shutdown();
+      // There is a bug (b/183340374) in gRPC that client doesn't try to close connections with
+      // shutdown() if the channel received GO_AWAY frames. Using shutdownNow() here as a
+      // workaround.
+      channel.shutdownNow();
       try {
         channel.awaitTermination(Integer.MAX_VALUE, SECONDS);
       } catch (InterruptedException e) {
