* add change to allow blaze info to skip Starlark build settings that start with --no prefix

Googler · copybara-github · commit f6cccae5b6f9 · 2022-01-28T07:19:42.000-08:00
* add unit tests for both info and clean commands

PiperOrigin-RevId: 424863510
diff --git a/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java b/src/main/java/com/google/devtools/build/lib/runtime/StarlarkOptionsParser.java
@@ -330,7 +330,7 @@ public static Pair<ImmutableList<String>, ImmutableList<String>> removeStarlarkO
       String potentialStarlarkFlag = name.substring(2);
       // Check if the string uses the "no" prefix for setting boolean flags to false, trim
       // off "no" if so.
-      if (name.startsWith("no")) {
+      if (potentialStarlarkFlag.startsWith("no")) {
         potentialStarlarkFlag = potentialStarlarkFlag.substring(2);
       }
       // Check if the string contains a value, trim off the value if so.

Original file line number	Diff line number	Diff line change
`@@ -330,7 +330,7 @@ public static Pair<ImmutableList<String>, ImmutableList<String>> removeStarlarkO`
`330`	`330`	`String potentialStarlarkFlag = name.substring(2);`
`331`	`331`	`// Check if the string uses the "no" prefix for setting boolean flags to false, trim`
`332`	`332`	`// off "no" if so.`
`333`		`- if (name.startsWith("no")) {`
	`333`	`+ if (potentialStarlarkFlag.startsWith("no")) {`
`334`	`334`	`potentialStarlarkFlag = potentialStarlarkFlag.substring(2);`
`335`	`335`	`}`
`336`	`336`	`// Check if the string contains a value, trim off the value if so.`