Bazel linux client: Have GetSelfPath always return "/proc/self/exe" -- don't do any symlink resolution.

haxorz · copybara-github · commit d79ec039a42f · 2019-03-06T14:56:07.000-08:00
The eager symlink resolution is unnecessary.

RELNOTES:
PiperOrigin-RevId: 237126043
diff --git a/src/main/cpp/blaze_util_linux.cc b/src/main/cpp/blaze_util_linux.cc
@@ -82,19 +82,10 @@ void WarnFilesystemType(const string& output_base) {
 }
 
 string GetSelfPath() {
-  char buffer[PATH_MAX] = {};
-  ssize_t bytes = readlink("/proc/self/exe", buffer, sizeof(buffer));
-  if (bytes == sizeof(buffer)) {
-    // symlink contents truncated
-    bytes = -1;
-    errno = ENAMETOOLONG;
-  }
-  if (bytes == -1) {
-    BAZEL_DIE(blaze_exit_code::INTERNAL_ERROR)
-        << "error reading /proc/self/exe: " << GetLastErrorString();
-  }
-  buffer[bytes] = '\0';  // readlink does not NUL-terminate
-  return string(buffer);
+  // The file to which this symlink points could change contents or go missing
+  // concurrent with execution of the Bazel client, so we don't eagerly resolve
+  // it.
+  return "/proc/self/exe";
 }
 
 uint64_t GetMillisecondsMonotonic() {
diff --git a/src/main/cpp/blaze_util_platform.h b/src/main/cpp/blaze_util_platform.h
@@ -95,7 +95,8 @@ void SigPrintf(const char *format, ...);
 
 std::string GetProcessIdAsString();
 
-// Get the absolute path to the binary being executed.
+// Get an absolute path to the binary being executed that is guaranteed to be
+// readable.
 std::string GetSelfPath();
 
 // Returns the directory Bazel can use to store output.
