Make StarlarkExecGroupContext use AutoValue.

katre · copybara-github · commit b9519f92f8ce · 2021-04-08T13:18:41.000-07:00
This gives reasonable equals and hashCode behavior.

PiperOrigin-RevId: 367493368
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkExecGroupCollection.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkExecGroupCollection.java
@@ -82,7 +82,7 @@ public StarlarkExecGroupContext getIndex(StarlarkSemantics semantics, Object key
           String.join(", ", getScrubbedExecGroups()));
     }
     ToolchainContextApi toolchainContext = toolchainCollection().getToolchainContext(execGroup);
-    return new StarlarkExecGroupContext(toolchainContext);
+    return new AutoValue_StarlarkExecGroupCollection_StarlarkExecGroupContext(toolchainContext);
   }
 
   private static String castGroupName(Object key) throws EvalException {
@@ -113,17 +113,10 @@ private List<String> getScrubbedExecGroups() {
    * The starlark object that is returned by ctx.exec_groups[<name>]. Gives information about that
    * exec group.
    */
-  public static class StarlarkExecGroupContext implements ExecGroupContextApi {
-    ToolchainContextApi toolchainContext;
-
-    private StarlarkExecGroupContext(ToolchainContextApi toolchainContext) {
-      this.toolchainContext = toolchainContext;
-    }
-
+  @AutoValue
+  public abstract static class StarlarkExecGroupContext implements ExecGroupContextApi {
     @Override
-    public ToolchainContextApi toolchains() {
-      return toolchainContext;
-    }
+    public abstract ToolchainContextApi toolchains();
 
     @Override
     public void repr(Printer printer) {
