Implement describeKey for more actions

fmeum · copybara-github · commit adaf299e40a1 · 2024-02-20T03:15:13.000-08:00
Closes #21380. PiperOrigin-RevId: 608540776 Change-Id: Ic058e199fb68e73018d8ae10cd43d86050ec05d9
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/actions/SymlinkAction.java b/src/main/java/com/google/devtools/build/lib/analysis/actions/SymlinkAction.java
@@ -313,6 +313,11 @@ protected void computeKey(
     }
   }
 
+  @Override
+  public String describeKey() {
+    return String.format("GUID: %s\ninputPath: %s\n", GUID, inputPath);
+  }
+
   @Override
   public String getMnemonic() {
     return targetType == TargetType.EXECUTABLE ? "ExecutableSymlink" : "Symlink";
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/actions/TemplateExpansionAction.java b/src/main/java/com/google/devtools/build/lib/analysis/actions/TemplateExpansionAction.java
@@ -195,6 +195,13 @@ protected void computeKey(
     }
   }
 
+  @Override
+  public String describeKey() {
+    return String.format(
+        "GUID: %s\nmakeExecutable: %s\ntemplate: %s\nsubstitutions: %s\n",
+        GUID, makeExecutable, template.getKey(), substitutions);
+  }
+
   @Override
   public String getMnemonic() {
     return "TemplateExpand";
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/UnresolvedSymlinkAction.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/UnresolvedSymlinkAction.java
@@ -93,6 +93,11 @@ protected void computeKey(
     fp.addPath(target);
   }
 
+  @Override
+  public String describeKey() {
+    return String.format("GUID: %s\ntarget: %s\n", GUID, target);
+  }
+
   @Override
   public String getMnemonic() {
     return "UnresolvedSymlink";

Original file line number	Diff line number	Diff line change
`@@ -313,6 +313,11 @@ protected void computeKey(`
`313`	`313`	`}`
`314`	`314`	`}`
`315`	`315`
	`316`	`+ @Override`
	`317`	`+ public String describeKey() {`
	`318`	`+ return String.format("GUID: %s\ninputPath: %s\n", GUID, inputPath);`
	`319`	`+ }`
	`320`	`+`
`316`	`321`	`@Override`
`317`	`322`	`public String getMnemonic() {`
`318`	`323`	`return targetType == TargetType.EXECUTABLE ? "ExecutableSymlink" : "Symlink";`
Original file line number	Diff line number	Diff line change
`@@ -195,6 +195,13 @@ protected void computeKey(`
`195`	`195`	`}`
`196`	`196`	`}`
`197`	`197`
	`198`	`+ @Override`
	`199`	`+ public String describeKey() {`
	`200`	`+ return String.format(`
	`201`	`+ "GUID: %s\nmakeExecutable: %s\ntemplate: %s\nsubstitutions: %s\n",`
	`202`	`+ GUID, makeExecutable, template.getKey(), substitutions);`
	`203`	`+ }`
	`204`	`+`
`198`	`205`	`@Override`
`199`	`206`	`public String getMnemonic() {`
`200`	`207`	`return "TemplateExpand";`