Rename ToolchainCollection.getExecGroups to getExecGroupNames.

katre · copybara-github · commit 9b18d951a528 · 2021-05-06T08:00:36.000-07:00
PiperOrigin-RevId: 372343218
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java b/src/main/java/com/google/devtools/build/lib/analysis/RuleContext.java
@@ -1414,7 +1414,7 @@ private ImmutableTable<String, String, String> parseExecProperties(
       return ImmutableTable.of();
     } else {
       return parseExecProperties(
-          execProperties, toolchainContexts == null ? null : toolchainContexts.getExecGroups());
+          execProperties, toolchainContexts == null ? null : toolchainContexts.getExecGroupNames());
     }
   }
 
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/ToolchainCollection.java b/src/main/java/com/google/devtools/build/lib/analysis/ToolchainCollection.java
@@ -55,7 +55,7 @@ public ImmutableSet<Label> getResolvedToolchains() {
         .collect(toImmutableSet());
   }
 
-  public ImmutableSet<String> getExecGroups() {
+  public ImmutableSet<String> getExecGroupNames() {
     return getContextMap().keySet();
   }
 
diff --git a/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkExecGroupCollection.java b/src/main/java/com/google/devtools/build/lib/analysis/starlark/StarlarkExecGroupCollection.java
@@ -62,7 +62,7 @@ public static boolean isValidGroupName(String execGroupName) {
   public boolean containsKey(StarlarkSemantics semantics, Object key) throws EvalException {
     String group = castGroupName(key);
     return !DEFAULT_EXEC_GROUP_NAME.equals(group)
-        && toolchainCollection().getExecGroups().contains(group);
+        && toolchainCollection().getExecGroupNames().contains(group);
   }
 
   /**
@@ -104,7 +104,7 @@ public void repr(Printer printer) {
   }
 
   private List<String> getScrubbedExecGroups() {
-    return toolchainCollection().getExecGroups().stream()
+    return toolchainCollection().getExecGroupNames().stream()
         .filter(group -> !DEFAULT_EXEC_GROUP_NAME.equals(group))
         .sorted()
         .collect(Collectors.toList());

Original file line number	Diff line number	Diff line change
`@@ -1414,7 +1414,7 @@ private ImmutableTable<String, String, String> parseExecProperties(`
`1414`	`1414`	`return ImmutableTable.of();`
`1415`	`1415`	`} else {`
`1416`	`1416`	`return parseExecProperties(`
`1417`		`- execProperties, toolchainContexts == null ? null : toolchainContexts.getExecGroups());`
	`1417`	`+ execProperties, toolchainContexts == null ? null : toolchainContexts.getExecGroupNames());`
`1418`	`1418`	`}`
`1419`	`1419`	`}`
`1420`	`1420`
Original file line number	Diff line number	Diff line change
`@@ -55,7 +55,7 @@ public ImmutableSet<Label> getResolvedToolchains() {`
`55`	`55`	`.collect(toImmutableSet());`
`56`	`56`	`}`
`57`	`57`
`58`		`- public ImmutableSet<String> getExecGroups() {`
	`58`	`+ public ImmutableSet<String> getExecGroupNames() {`
`59`	`59`	`return getContextMap().keySet();`
`60`	`60`	`}`
`61`	`61`