Correct error runfiles cc_shared_library (#14998)

oquenchil · web-flow · commit 78f03110e0da · 2022-03-09T01:31:47.000+11:00
Fix runfiles in cc_shared_library #1494 misses a key part which was to actually add the precompiled libraries to the runfiles provider. There was a test but this used a cc_binary which gave the false sense of things working correctly since the cc_binary is able to get the runfiles from the CcInfo and add it itself. Changed test to use a py_test instead. Cherrypick of 426188c
diff --git a/src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl b/src/main/starlark/builtins_bzl/common/cc/experimental_cc_shared_library.bzl
@@ -507,6 +507,8 @@ def _cc_shared_library_impl(ctx):
         if precompiled_dynamic_library.resolved_symlink_dynamic_library != None:
             precompiled_only_dynamic_libraries_runfiles.append(precompiled_dynamic_library.resolved_symlink_dynamic_library)
 
+    runfiles = runfiles.merge(ctx.runfiles(files = precompiled_only_dynamic_libraries_runfiles))
+
     return [
         DefaultInfo(
             files = depset(library),
