Remove restriction on generate_pdb_file to be only used in dbg and fastbuild mode

meteorcloudy · copybara-github · commit 6dc941e58dfc · 2021-05-06T08:45:23.000-07:00
Users may want to build in opt mode and still want the pdb file to be a linking action output. See bazelbuild/rules_cc#94 (comment) RELNOTES: None PiperOrigin-RevId: 372351216
diff --git a/tools/cpp/windows_cc_toolchain_config.bzl b/tools/cpp/windows_cc_toolchain_config.bzl
@@ -666,10 +666,6 @@ def _impl(ctx):
 
         generate_pdb_file_feature = feature(
             name = "generate_pdb_file",
-            requires = [
-                feature_set(features = ["dbg"]),
-                feature_set(features = ["fastbuild"]),
-            ],
         )
 
         output_execpath_flags_feature = feature(

Original file line number	Diff line number	Diff line change
`@@ -666,10 +666,6 @@ def _impl(ctx):`
`666`	`666`
`667`	`667`	`generate_pdb_file_feature = feature(`
`668`	`668`	`name = "generate_pdb_file",`
`669`		`- requires = [`
`670`		`- feature_set(features = ["dbg"]),`
`671`		`- feature_set(features = ["fastbuild"]),`
`672`		`- ],`
`673`	`669`	`)`
`674`	`670`
`675`	`671`	`output_execpath_flags_feature = feature(`