Disable IncludeValidation for ObjC in bazel (#14440)

amberdixon · googlewalt · web-flow · commit 2fb7dfe7b35b · 2021-12-16T22:56:39.000+11:00
IncludeValidation was disabled for ObjC for bazel versions up to 4.2. We are getting reports that turning it on in 5.0 causes breakages due to Apple (?) clang emitting absolute paths in .d files. Fixes #14346. PiperOrigin-RevId: 415251009 Co-authored-by: waltl <waltl@google.com>
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java
@@ -128,7 +128,7 @@ public void validateAttributes(RuleContext ruleContext) {
 
   @Override
   public boolean needsIncludeValidation() {
-    return true;
+    return language != Language.OBJC;
   }
 
   @Override

Original file line number	Diff line number	Diff line change
`@@ -128,7 +128,7 @@ public void validateAttributes(RuleContext ruleContext) {`
`128`	`128`
`129`	`129`	`@Override`
`130`	`130`	`public boolean needsIncludeValidation() {`
`131`		`- return true;`
	`131`	`+ return language != Language.OBJC;`
`132`	`132`	`}`
`133`	`133`
`134`	`134`	`@Override`