Fix error prone ComparisonOutOfRange in ZipTester

hvadehra · copybara-github · commit 09188a906a8c · 2023-06-29T05:27:14.000-07:00
`filename` has type `byte[]`, so the range of each element is `[-128,127]`

PiperOrigin-RevId: 544327350
Change-Id: I58b4829044fa5891157c4ef7dbc3e70fb458e33f
diff --git a/src/java_tools/singlejar/javatests/com/google/devtools/build/singlejar/ZipTester.java b/src/java_tools/singlejar/javatests/com/google/devtools/build/singlejar/ZipTester.java
@@ -228,7 +228,7 @@ private void readEntry() throws IOException {
 
     String name = new String(filename, "UTF-8");
     for (int i = 0; i < filename.length; i++) {
-      if ((filename[i] < ' ') || (filename[i] > 127)) {
+      if ((filename[i] < ' ')) {
         warn(entryDesc + ": file name has unexpected non-ascii characters");
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ private void readEntry() throws IOException {`
`228`	`228`
`229`	`229`	`String name = new String(filename, "UTF-8");`
`230`	`230`	`for (int i = 0; i < filename.length; i++) {`
`231`		`- if ((filename[i] < ' ') \|\| (filename[i] > 127)) {`
	`231`	`+ if ((filename[i] < ' ')) {`
`232`	`232`	`warn(entryDesc + ": file name has unexpected non-ascii characters");`
`233`	`233`	`}`
`234`	`234`	`}`