Disable IncludeValidation for ObjC in bazel

googlewalt · copybara-github · commit 005361c895da · 2021-12-09T06:34:20.000-08:00
IncludeValidation was disabled for ObjC for bazel versions up to 4.2. We are getting reports that turning it on in 5.0 causes breakages due to Apple (?) clang emitting absolute paths in .d files. Fixes #14346. PiperOrigin-RevId: 415251009
diff --git a/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java b/src/main/java/com/google/devtools/build/lib/bazel/rules/cpp/BazelCppSemantics.java
@@ -135,7 +135,7 @@ public void validateAttributes(RuleContext ruleContext) {
 
   @Override
   public boolean needsIncludeValidation() {
-    return true;
+    return language != Language.OBJC;
   }
 
   @Override

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public void validateAttributes(RuleContext ruleContext) {`
`135`	`135`
`136`	`136`	`@Override`
`137`	`137`	`public boolean needsIncludeValidation() {`
`138`		`- return true;`
	`138`	`+ return language != Language.OBJC;`
`139`	`139`	`}`
`140`	`140`
`141`	`141`	`@Override`