fix(xcode_support): handle Xcode version starting with path separator#481
Merged
brentleyjones merged 1 commit intobazelbuild:masterfrom Nov 3, 2025
Merged
Conversation
ma-oli
requested review from
aaronsky,
adincebic,
brentleyjones,
keith,
luispadron and
mattrobmattrob
as code owners
keith
approved these changes
Nov 3, 2025
When Xcode version is passed as a directory, the version check currently errors out as it obviously cannot compare versions. We're gonna assume that if the user passes Xcode as a directory, they're ok managing the features themselves, and we'll assume they're on the latest and greatest Xcode. So we'll have that logic return True.
auto-merge was automatically disabled
November 3, 2025 16:55
Head branch was pushed to by a user without write access
ma-oli
force-pushed
the
handle-xcode-version-path
branch
from
913478e to
69d6ec0
Compare
brentleyjones
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Xcode version is passed as a directory, the version check currently errors out as it obviously cannot compare versions. We're gonna assume that if the user passes Xcode as a directory, they're ok managing the features themselves, and we'll assume they're on the latest and greatest Xcode. So we'll have that logic return True.