Skip post-processing binary with no -o flag#479
Merged
Conversation
Since cc_common setup can be called in a way where the output_execpath is never set, I think we have to support just skipping this. Fixes #476
keith
requested review from
aaronsky,
adincebic,
brentleyjones,
luispadron and
mattrobmattrob
as code owners
brentleyjones
approved these changes
Oct 27, 2025
adincebic
approved these changes
Oct 27, 2025
Member
Author
|
for future reference we could potentially compute the output binary name ourselves, it seems like in the case you pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since cc_common setup can be called in a way where the output_execpath
is never set, I think we have to support just skipping this.
Fixes #476