Conversation
keith
requested review from
aaronsky,
brentleyjones,
luispadron and
mattrobmattrob
as code owners
brentleyjones
approved these changes
Oct 15, 2025
keith
force-pushed
the
ks/fix-not-stripping-binaries
branch
from
857b325 to
cce082d
Compare
aaronsky
approved these changes
Oct 15, 2025
Since 9975f41, binaries were only stripped if dSYMs were also enabled since strip was called after dsymutil. Before that change it was stripped with `-Wl,-S` so that happened automatically regardless of if dsymutil was called.
keith
force-pushed
the
ks/fix-not-stripping-binaries
branch
from
cce082d to
0e8b68e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 9975f41, binaries were only
stripped if dSYMs were also enabled since strip was called after
dsymutil. Before that change it was stripped with
-Wl,-Sso thathappened automatically regardless of if dsymutil was called.