Merged
Conversation
keith
requested review from
aaronsky,
brentleyjones,
luispadron and
mattrobmattrob
as code owners
mattrobmattrob
approved these changes
Oct 15, 2025
aaronsky
approved these changes
Oct 15, 2025
brentleyjones
approved these changes
Oct 15, 2025
keith
force-pushed
the
ks/add-missing-zero_ar_date-env-var
branch
from
2525d76 to
1d1c52e
Compare
keith
force-pushed
the
ks/add-missing-zero_ar_date-env-var
branch
from
1d1c52e to
c25e90c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I accidentally dropped this in
6e0fdb1 which lead to #465
The reason we didn't spot this earlier is doing
-Wl,-Sremoved thedebug info anyways, so this revealed another issue with that change that
all debug info isn't stripped, but we should have this either way and
can fix that after.
Fixes #465