apple_genrule(): stop using some legacy features#431
Merged
aaronsky merged 2 commits intobazelbuild:masterfrom Sep 20, 2025
Merged
apple_genrule(): stop using some legacy features#431aaronsky merged 2 commits intobazelbuild:masterfrom
aaronsky merged 2 commits intobazelbuild:masterfrom
Conversation
EdSchouten
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
Contributor
Author
|
Am I correct that the CI failure I'm seeing is caused by an infrastructure failure, and not the change at hand? |
Member
|
Looks like buildifier is showing an unused variable |
Contributor
Author
|
Aaah, I had to expand the output a bit to get a proper error message. Silly that it doesn't do that by default. |
EdSchouten
force-pushed
the
eschouten/20250909-legacy
branch
from
b752183 to
f4c886b
Compare
keith
approved these changes
Sep 9, 2025
auto-merge was automatically disabled
September 9, 2025 18:19
Head branch was pushed to by a user without write access
EdSchouten
force-pushed
the
eschouten/20250909-legacy
branch
from
f4c886b to
57ab93d
Compare
- rule()'s output_to_genfiles stopped being meaningful when bazel-genfiles/ and bazel-bin/ consolidated. - ctx.actions.run()'s input_manifests argument is a legacy argument that is documented as being ignored.
EdSchouten
force-pushed
the
eschouten/20250909-legacy
branch
from
57ab93d to
84165e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rule()'s output_to_genfiles stopped being meaningful when bazel-genfiles/ and bazel-bin/ consolidated.
ctx.actions.run()'s input_manifests argument is a legacy argument that is documented as being ignored.