Update C++ standard default to 17 #376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsky
requested review from
BalestraPatrick,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
mattrobmattrob
approved these changes
Mar 15, 2025
mattrobmattrob
left a comment
mattrobmattrob
left a comment
There was a problem hiding this comment.
Seems reasonable to me. Just want to organize any other major version bump changes if/when we merge this.
Member
|
best reason to do this is that the default C++ toolchain did as well 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In accordance with Google's Foundational C++ Support matrix, and given other Google projects have moved to adopt C++17 as a minimum or default (protobuf, rules_cc), I'd like us to consider bumping this version in apple_support as well.
This constitutes a breaking change. It uses the change made in #219 as a reference.