Remove no_uuid and codesigning workarounds when building wrapped_clang. #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkosiba
requested review from
BalestraPatrick,
aaronsky,
brentleyjones,
keith,
luispadron,
mattrobmattrob and
thii
as code owners
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
mkosiba
force-pushed
the
upstream_no_uuid
branch
from
abe5ec5 to
83c47d9
Compare
Member
|
If we remove this I think we should remove the codesigning workaround too |
Contributor
Author
happy to add that to the PR (I'm assuming we remove |
Member
|
the issue you linked actually wasn't the core one, since most folks aren't using lld for apple platforms. both the no_uuid case, and the codesigning case were tied up in the same issue which was clang was using a random tmpdir filename in the binary when compiling for multiple architectures. I fixed this here https://github.com/llvm/llvm-project//commit/17386cb4dc89afad62623b9bc08516b99b9c6df7 both of the linker bugs I believe have also been fixed, but that clang change solved them regardless original commits for future reference bazelbuild/bazel@917e15e bazelbuild/bazel@80c56ff |
The core problem was fixed in https://reviews.llvm.org/D111269 and these workarounds are no longer necessary.
mkosiba
force-pushed
the
upstream_no_uuid
branch
from
83c47d9 to
07c15df
Compare
mkosiba
changed the title
keith
approved these changes
Feb 20, 2025
Contributor
Author
|
thanks @keith! I think you (or another contributor) will have to merge the PR on my behalf as well as I'm not authorized. |
Member
|
yea np I was just giving it some time in case anyone else wanted to review |
Member
|
thanks! |
ZhongRuoyu
added a commit
to ZhongRuoyu/bazel
that referenced
this pull request
Sep 17, 2025
These workarounds were added (in 76b3c24, bazelbuild#14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. Signed-off-by: Ruoyu Zhong <[email protected]>
This was referenced Sep 17, 2025
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 25, 2025
These workarounds were added (in 76b3c24, #14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes #27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 25, 2025
These workarounds were added (in 76b3c24, bazelbuild#14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes bazelbuild#27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 25, 2025
These workarounds were added (in 76b3c24, bazelbuild#14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes bazelbuild#27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 25, 2025
These workarounds were added (in 76b3c24, bazelbuild#14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes bazelbuild#27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb
meteorcloudy
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 26, 2025
These workarounds were added (in 76b3c24, bazelbuild#14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes bazelbuild#27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb
github-merge-queue bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 26, 2025
…27089) These workarounds were added (in 76b3c24, #14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes #27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb Commit 433e0e7 Co-authored-by: Ruoyu Zhong <[email protected]>
iancha1992
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 26, 2025
…27087) These workarounds were added (in 76b3c24, #14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes #27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb Commit 433e0e7 Co-authored-by: Ruoyu Zhong <[email protected]>
github-merge-queue bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 29, 2025
…27088) These workarounds were added (in 76b3c24, #14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes #27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb Commit 433e0e7 Co-authored-by: Ruoyu Zhong <[email protected]>
github-merge-queue bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Sep 29, 2025
…27088) These workarounds were added (in 76b3c24, #14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes #27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb Commit 433e0e7 Co-authored-by: Ruoyu Zhong <[email protected]>
iancha1992
pushed a commit
to iancha1992/bazel
that referenced
this pull request
Oct 6, 2025
…azelbuild#27088) These workarounds were added (in 76b3c24, bazelbuild#14168) to enable hermetic macOS toolchain setup, but are no longer necessary as far as I can tell (see also: bazelbuild/apple_support@44c43c715a, bazelbuild/apple_support#373). It should be noted that macOS Tahoe seems to have enforced that LC_UUID must be present in executables. Executables without it are rejected by dyld with `dyld: missing LC_UUID load command`, effectively stops Bazel from working. It is therefore necessary to drop these workarounds here and in Apple support (done in bazelbuild/apple_support@44c43c715a) in order for Bazel to function on macOS Tahoe. CC @keith Closes bazelbuild#27014. PiperOrigin-RevId: 811436317 Change-Id: I9d819fdbc2b76ad4ee5abb1fc0c4eb1ee1b442fb Commit bazelbuild@433e0e7 Co-authored-by: Ruoyu Zhong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core problem was fixed in https://reviews.llvm.org/D111269 and these
workarounds are no longer necessary.