Update C++ standard default to 14 #219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mirroring bazelbuild/bazel#18280 so it's easier to swap between the toolchains
Member
Author
|
we should only merge if that upstream change does |
keith
requested review from
BalestraPatrick,
brentleyjones,
mattrobmattrob,
segiddins and
thii
as code owners
Member
Author
|
hrm maybe we should wait closer to 7.x merging, kinda a lose lose |
Collaborator
|
Since it merged upstream, I think it's fine to merge here? Just need to call it out in the release notes, in case people want a different value and they need to override it locally. |
brentleyjones
approved these changes
May 15, 2023
keith
pushed a commit
that referenced
this pull request
Mar 18, 2025
In accordance with Google's [Foundational C++ Support matrix](https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md), and given other Google projects have moved to adopt C++17 as a minimum or default ([protobuf](protocolbuffers/protobuf@fe53593), [rules_cc](https://github.com/search?q=repo%3Abazelbuild%2Frules_cc+%22-std%22&type=code)), I'd like us to consider bumping this version in apple_support as well. This constitutes a breaking change. It uses the change made in #219 as a reference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mirroring bazelbuild/bazel#18280 so it's easier
to swap between the toolchains