Add Apple CC toolchain setup #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Investigation related to bazelbuild/bazel#15041 (comment) |
keith
requested review from
BalestraPatrick,
brentleyjones,
segiddins and
thii
as code owners
keith
force-pushed
the
ks/add-example-toolchains-setup
branch
from
711b8e5 to
65e700a
Compare
keith
force-pushed
the
ks/add-example-toolchains-setup
branch
2 times, most recently
from
e7c43f0 to
010569f
Compare
We can likely simplify this later
If you're calling this you want Xcode
keith
force-pushed
the
ks/add-example-toolchains-setup
branch
from
c55baea to
2a3bb18
Compare
Member
Author
|
Overview / approach of changes:
|
thii
reviewed
Jan 13, 2023
Co-authored-by: Thi Doãn <[email protected]>
Co-authored-by: Thi Doãn <[email protected]>
brentleyjones
approved these changes
Jan 17, 2023
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 10, 2023
This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes #15041 Closes #16619. PiperOrigin-RevId: 515546196 Change-Id: Ia54b53e7093c1edbfe8276730aaed5a11a94a027
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 14, 2023
*** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes #1... *** PiperOrigin-RevId: 516486823 Change-Id: If9b2542699cf8704e0a511e684d8519468ddd937
copybara-service bot
pushed a commit
to bazelbuild/bazel
that referenced
this pull request
Mar 22, 2023
*** Reason for rollback *** Roll forward with fix *** Original change description *** Automated rollback of commit d56dc18. *** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolc *** PiperOrigin-RevId: 518560017 Change-Id: I00a106b68eac982e3d903531d5db48ae053f9301
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes bazelbuild#15041 Closes bazelbuild#16619. PiperOrigin-RevId: 515546196 Change-Id: Ia54b53e7093c1edbfe8276730aaed5a11a94a027
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
*** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolchain, but it doesn't handle as many platform specific features as the previous toolchain. Fixes bazelbuild#1... *** PiperOrigin-RevId: 516486823 Change-Id: If9b2542699cf8704e0a511e684d8519468ddd937
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
*** Reason for rollback *** Roll forward with fix *** Original change description *** Automated rollback of commit d56dc18. *** Reason for rollback *** Breaks builds internally. *** Original change description *** Move Apple toolchain setup to apple_support This moves the CC toolchain for building Apple platforms besides macOS to the apple_support repo bazelbuild/apple_support#113 The default unix toolchain is now used if someone wants to build for macOS without the apple_support toolc *** PiperOrigin-RevId: 518560017 Change-Id: I00a106b68eac982e3d903531d5db48ae053f9301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates the Apple CC toolchain from bazel into this repo. This allows this to evolve and be updated without a full bazel udpate. Bazel's built in unix toolchain can still be used to build macOS C++ targets, but this repo handles a wider variety of Apple specific flags and requires you have Xcode installed.