Update rules_apple to 2.3.0 + remove bitcode support#727
Conversation
Handle bazelbuild/rules_apple#1534 and update `rules_apple` to https://github.com/bazelbuild/rules_apple/releases/tag/2.3.0 (bazelbuild/rules_apple@915ac30). Signed-off-by: Matt Robinson <[email protected]>
mattrobmattrob
requested review from
luispadron and
thiagohmcruz
and removed request for
thiagohmcruz
thiagohmcruz
left a comment
thiagohmcruz
left a comment
There was a problem hiding this comment.
Do we expect the code being removed to break the "Bazel 5 + old rules_apple" code path? Any way we can verify that?
|
I'm not entirely sure why we're supporting two Bazel versions on main. Should we not instead create a branch specifically for Bazel 5? This makes maintenance really tough... |
|
I was relying on |
|
Oh my bad, forgot that there's an explicitly job to cover that, it should be enough yeah @luispadron there's a README IIRC to cover the LTS support, maybe a start is to review that and propose changes / a diff approach? I def can see the pain points in maintaining it, at the same time it was introduced to help enforce there is at least one code path we consider "stable". That said, there's other ways to achieve the same thing and any approach will have trade-offs to discuss IMO. |
3 participants
Update
rules_appleto https://github.com/bazelbuild/rules_apple/releases/tag/2.3.0 (bazelbuild/rules_apple@915ac30) and handle bazelbuild/rules_apple#1534.