docs: Document how to use a distinct output base#367
Merged
cameron-martin merged 4 commits intobazel-contrib:masterfrom Apr 8, 2024
Merged
docs: Document how to use a distinct output base#367cameron-martin merged 4 commits intobazel-contrib:masterfrom
cameron-martin merged 4 commits intobazel-contrib:masterfrom
Conversation
cameron-martin
force-pushed
the
distinct-output-base
branch
from
42f7efc to
5d44fba
Compare
vogelsgesang
approved these changes
Apr 6, 2024
Collaborator
vogelsgesang
left a comment
vogelsgesang
left a comment
There was a problem hiding this comment.
Thanks for addressing this!
Two smaller nits, feel free to ignore them if you disagree
Collaborator
Author
|
@vogelsgesang Looks like the email of yours that GitHub used when I clicked "commit suggestion" hasn't signed the CLA. |
This flips the `bazel.queriesShareServer` default back to `true`, since I think it was a bit hasty in bazel-contrib#355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.
cameron-martin
force-pushed
the
distinct-output-base
branch
from
3f9911a to
dd42edf
Compare
Collaborator
|
Thanks for the heads-up! Interesting that Github uses another one of my email addresses for commit suggestions... I will have to figure out how to change that... |
jfirebaugh
approved these changes
Apr 8, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flips the
bazel.queriesShareServerdefault back totrue, since I think it was a bit hasty in #355 to break everyone not on the latest bazel version. Instead, I have added a section to the docs, linked from the setting, describing how to safely disable this option.