fix: patch regexp pattern until gazelle next release#99
Merged
sitaktif merged 3 commits intobazel-contrib:mainfrom Jan 28, 2025
Merged
fix: patch regexp pattern until gazelle next release#99sitaktif merged 3 commits intobazel-contrib:mainfrom
sitaktif merged 3 commits intobazel-contrib:mainfrom
Conversation
darkrift
changed the title
Contributor
Author
|
@sitaktif if you could take a look at this, it's quite a blocker to be able to run against Bazel 8. This patch is temporary until bazel-gazelle cuts a new release as that patch (along with a test) has already been merged in bazel-gazelle. Once this is merged, could you also cut a release ? |
sitaktif
approved these changes
Jan 28, 2025
Collaborator
sitaktif
left a comment
sitaktif
left a comment
There was a problem hiding this comment.
LGTM, thanks for submitting the patch 👍
Collaborator
|
@darkrift released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies part of this patch until a new release of bazel-gazelle is made.