Update bazel-gazelle (to allow + in repo names) (for bazel 8)#97
Conversation
kriscfoster
changed the title
+ in repo names)+ in repo names) (for bazel 8)
|
Thanks for the contribution! I agree with the goal, but unfortunately the update seems to be failing on CI... I pushed a couple of commits trying to fix things, but no joy! If you can get things green, I'm happy to merge! |
kriscfoster
force-pushed
the
update-bazel-gazelle
branch
from
56acae0 to
4c2b408
Compare
Thanks. I think I'm pretty close now (one test failure left). I'll let you know here once I'm ready for a review. |
|
Tests are passing now @illicitonion. It took some time to debug a strange regression (I think) caused by bazel-contrib/bazel-gazelle#1911 (mainly in I know the work-around isn't the cleanest but it's all that I have time to do right now. |
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
Thanks for persisting through this! Just one small change to think about/do and let's get this merged!
2 participants
This is required for bazel 8 compatibility.
Currently hitting
failed to parse cquery result: label parse error: repository has invalid characters: "@@rules_python++python+python_3_11_x86_64-unknown-linux-gnu//:python_runtimes".This should be fixed by bazel-contrib/bazel-gazelle#1856.