fix: targets spuriously returned in cache case#124
Merged
sitaktif merged 1 commit intobazel-contrib:mainfrom Apr 23, 2026
Merged
fix: targets spuriously returned in cache case#124sitaktif merged 1 commit intobazel-contrib:mainfrom
sitaktif merged 1 commit intobazel-contrib:mainfrom
Conversation
Remove the "NewTarget" case, which can never be reached because: 1. beforeMetadata.TransitiveConfiguredTargets is a superset of beforeMetadata.MatchingTargets, and 2. at this point in the function, beforeMetadata.MatchingTargets is known to contain that same label and configuration. Doing this also addresses an issue where spurious targets were returned on a result cache hit: the codepath was looking for configured target structs, but when retrieving hashes from the cache, these are not populated in the first place, only the resulting hashes are.
sitaktif
force-pushed
the
result-cache-spurious-results
branch
from
93b7b69 to
8640bcd
Compare
gibfahn
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid returning spurious targets on a result cache hit: the codepath was looking for configured target structs, but when retrieving hashes from the cache, these are not populated (to save significant amounts of space).