Skip to content

Use cquery's --output_file if supported#115

Merged
sitaktif merged 2 commits intobazel-contrib:mainfrom
fmeum:main
Jul 9, 2025
Merged

Use cquery's --output_file if supported#115
sitaktif merged 2 commits intobazel-contrib:mainfrom
fmeum:main

Conversation

@fmeum
Copy link
Copy Markdown
Member

@fmeum fmeum commented Jul 7, 2025

Bazel command output is included in the BES, which can cause excessive BES traffic for large cquery results. Instead, use the --output_file option introduced in 8.2.0.

Also test in a matrix with all supported Bazel versions, which requires changes to the protos under third_party.

@fmeum fmeum requested review from illicitonion and sitaktif July 7, 2025 11:51
@fmeum fmeum force-pushed the main branch 2 times, most recently from 8391e50 to fc8f06b Compare July 7, 2025 12:48
@fmeum
Copy link
Copy Markdown
Member Author

fmeum commented Jul 7, 2025

This PR requires an update to the branch protection rules.

Comment thread pkg/bazel.go
@fmeum fmeum requested a review from dziemba July 8, 2025 12:44
Copy link
Copy Markdown

@dziemba dziemba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

Copy link
Copy Markdown
Collaborator

@sitaktif sitaktif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmeum fmeum enabled auto-merge (squash) July 9, 2025 09:56
@fmeum fmeum disabled auto-merge July 9, 2025 09:56
@sitaktif
Copy link
Copy Markdown
Collaborator

sitaktif commented Jul 9, 2025

Looks like there's some weirdness going on with that non-matrix presubmit job (which doesn't show up in the Actions tab). I'll merge as is, assuming that it's a Github bug, and that it won't happen in a new PR.

@sitaktif
Copy link
Copy Markdown
Collaborator

sitaktif commented Jul 9, 2025

@fmeum before I merge, do you mind squashing commits 1 and 3?

fmeum added 2 commits July 9, 2025 13:47
Bazel command output is included in the BES, which can cause excessive BES traffic for large cquery results. Instead, use the `--output_file` option introduced in 8.2.0.
@fmeum
Copy link
Copy Markdown
Member Author

fmeum commented Jul 9, 2025

@fmeum before I merge, do you mind squashing commits 1 and 3?

Done!

Looks like there's some weirdness going on with that non-matrix presubmit job (which doesn't show up in the Actions tab). I'll merge as is, assuming that it's a Github bug, and that it won't happen in a new PR.

That's expected: branch protection matches actions by name, so it's still looking for the old one with its non-matrix name. You have to update the branch protection rule to look for the two new jobs.

@sitaktif
Copy link
Copy Markdown
Collaborator

sitaktif commented Jul 9, 2025

Thanks @fmeum, now I understand this comment :-)

@sitaktif sitaktif merged commit bcbdefe into bazel-contrib:main Jul 9, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants