Migrate from WORKSPACE to Bzlmod#110
Closed
darkrift wants to merge 18 commits intobazel-contrib:mainfrom
Closed
Conversation
Contributor
Author
|
There's only the part about build_external that I'm not sure about. Do we still need that ? It didn't trigger that error so far. |
sitaktif
reviewed
May 8, 2025
Collaborator
That references a pretty old issue. If we're not hitting the issue, I see no point in keeping it around 👍 |
Contributor
Author
|
Let's continue in #111 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migrates from the deprecated WORKSPACE style to bzlmod.
Summary of changes :
formatscriptcom_github_bazelbuild_bazel_gazelleThere are many other go dependencies that could be updated, but they were not directly required for this migration (even the gazelle update is subjective)
I also kept the rules_go dependency repo_name to the old naming to limit the changes and to be closer to the strict minimum for the bzlmod migration.