Canonicalize targets#108
Merged
illicitonion merged 11 commits intobazel-contrib:mainfrom May 1, 2025
Merged
Conversation
…on the visibility exception being a STRING_LIST rather than a LABEL_LIST
Contributor
Author
|
@illicitonion if you could review this :) |
Contributor
Author
sitaktif
reviewed
Apr 28, 2025
Contributor
Author
sitaktif
approved these changes
May 1, 2025
Collaborator
|
Ha, that is exactly what I meant, thanks for pointing it out. I'm ok to merge 👍 |
Collaborator
|
Please remember to squash your commits! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This canonicalize all the labels in all attributes found that are label related using the output of
bazel mod dump_repo_mapping ""for each commit.This addresses #105
It doesn't have any integration tests yet because it would be much better to leverage #104 which is still in the works but it was tested against our internal monorepo and the reproducer in #105
Label like attributes (string defined but has nodep = True) are special and handled as an exception as if they were labels, and thus also converted. (See this thread)