Pass --isolated to pip wheel invocation#389
Merged
thundergolfer merged 3 commits intobazel-contrib:masterfrom Jan 5, 2021
Merged
Pass --isolated to pip wheel invocation#389thundergolfer merged 3 commits intobazel-contrib:masterfrom
thundergolfer merged 3 commits intobazel-contrib:masterfrom
Conversation
This fixes the same issue as bazel-contrib#232 but in another place.
keith
force-pushed
the
ks/pass-isolated-to-pip-wheel-invocation
branch
from
41898bb to
03c0a39
Compare
thundergolfer
approved these changes
Jan 3, 2021
|
I can merge this @keith if you don't want to wait longer for the assigned reviewers to review. Up to you. 👍 |
Member
Author
|
seems fine with me ! |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the same issue as #232 but in another place.
What is the current behavior?
Currently bad user level pip.conf files break pip installations
What is the new behavior?
User level pip.conf files are ignored.
Does this PR introduce a breaking change?
Potentially if people are relying on user local pip.conf files. If they are they should likely be defining that in their build instead though.