Add all_whl_requirements to match all_requirements#377
Add all_whl_requirements to match all_requirements#377thundergolfer merged 3 commits intobazel-contrib:masterfrom
all_whl_requirements to match all_requirements#377Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
person142
force-pushed
the
all-whl-requirements
branch
from
77e42a6 to
2bbfedb
Compare
There was a problem hiding this comment.
@person142 Thanks for the contribution.
@thundergolfer This LGTM.
| name_key = name.replace("-", "_").replace(".", "_").lower() | ||
| return "{repo}//pypi__" + name_key | ||
|
|
||
| all_whl_requirements = [{whl_requirement_labels}] |
There was a problem hiding this comment.
Nit: Put this underneath all_requirements so the macros are separated visually from the static definitions.
person142
force-pushed
the
all-whl-requirements
branch
from
2bbfedb to
b6886f2
Compare
3 participants
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
There isn't an equivalent to
all_requirementsforwhl_requirement.What is the new behavior?
A list
all_whl_requirementsis added torequirements.bzlwhich contains all of the wheel targets.Does this PR introduce a breaking change?
Other information
The
all_whl_requirementslist is handy if you want to write a target that takes all of the wheels built byrules_pythonand upload them to a private wheelhouse say.