Skip to content

fix: Return repo_metadata from uv repository rule#3597

Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom
mortenmj:mmj/uv-reproducible
Feb 14, 2026
Merged

fix: Return repo_metadata from uv repository rule#3597
rickeylev merged 1 commit intobazel-contrib:mainfrom
mortenmj:mmj/uv-reproducible

Conversation

@mortenmj
Copy link
Contributor

This allows the uv repository rule to use the remote repo content cache.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mortenmj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the uv_repository rule by adjusting its return mechanism to leverage Bazel's repo_metadata feature. This modification is key for enabling the rule to interact effectively with Bazel's remote repository content cache, which will enhance build performance and consistency when fetching uv toolchain dependencies. The implementation also includes a safeguard to ensure backward compatibility with older Bazel versions that may not yet support this specific API.

Highlights

  • Repository Rule Return Value: The _uv_repo_impl function now returns repository_ctx.repo_metadata instead of a plain dictionary, which is essential for Bazel's remote repository content caching.
  • Bazel Version Compatibility: A check has been added to ensure compatibility with Bazel versions older than 8.3.0, which may not have the repo_metadata attribute on repository_ctx.
  • Remote Cache Utilization: This change enables the uv repository rule to properly utilize Bazel's remote repository content cache, leading to more efficient dependency fetching.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • python/uv/private/uv_repository.bzl
    • Modified the _uv_repo_impl function to return repository_ctx.repo_metadata for improved caching capabilities.
    • Introduced a conditional check for the presence of repository_ctx.repo_metadata to maintain compatibility with older Bazel versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request correctly implements the repo_metadata return value for the uv_repository rule, enabling the remote repository content cache in Bazel 8.3+. This is a great improvement for build performance. I've identified a couple of issues: one regarding the reproducibility check logic and another regarding the attributes included in the cache key.

@mortenmj mortenmj force-pushed the mmj/uv-reproducible branch 3 times, most recently from 3961988 to ab9dfbf Compare February 14, 2026 10:58
@mortenmj mortenmj force-pushed the mmj/uv-reproducible branch from ab9dfbf to ba579a3 Compare February 14, 2026 11:10
@rickeylev rickeylev enabled auto-merge February 14, 2026 21:53
@rickeylev rickeylev added this pull request to the merge queue Feb 14, 2026
Merged via the queue into bazel-contrib:main with commit 74e10bd Feb 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants