chore: print zipapp deprecation for non-windows platforms#3591
chore: print zipapp deprecation for non-windows platforms#3591rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request adjusts the behavior of the zipapp deprecation warning to reduce unnecessary output. By restricting the warning to non-Windows environments, it addresses the complexity of transitioning away from zipapp-based execution on Windows, preventing spam while still informing users on other platforms about the upcoming changes. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies the py_executable rule to only display the zipapp deprecation warning on non-Windows platforms. This is a sensible change to reduce log spam for Windows users, as noted in the description. The implementation is a simple conditional check which is correct and clear. The changes look good.
2 participants
Switching Windows off its zipapp based execution has turned out to be more tricky than
anticipated, so just print the warning for non-Windows platforms to reduce spam.