fix(pipstar): fix whl extraction and flip pipstar=true #3461

aignas · 2025-12-14T23:35:54Z

Attempt number 2. This should be smoother this time and should not cause
any breakage because we are not enabling any cross-building by default and
only the host wheels will be present.

Because we also started extracting using starlark APIs, some extra fixups
where needed because some wheels require extracting .data files into
correct paths. This also adds the INSTALLER file after extracting files to
signify that pipstar has installed the file.

Because we have stopped passing hermetic interpreter to the whl_library if
pipstar is enabled, we also needed to ensure that the code path is only enabled
if the extraction with pipstar is supported (i.e. bazel >= 8).

Fixes #2949

gemini-code-assist · 2025-12-14T23:36:07Z

Summary of Changes

Hello @aignas, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request flips the default setting for the pipstar feature to be enabled by default. This change aims to simplify the initial setup for users, as the feature will now be active without requiring explicit configuration. The author anticipates a smooth transition, noting that cross-building is not enabled by default, which should prevent any unexpected breakages.

Highlights

pipstar Default: The pipstar feature is now enabled by default, streamlining its adoption for users.
Configuration: Users can disable pipstar by setting the RULES_PYTHON_ENABLE_PIPSTAR environment variable to 0.
Feedback Request: If pipstar needs to be disabled, users are encouraged to comment on issue feat: enable pipstar by default #2949.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request correctly enables the pipstar feature by default, which is a significant step forward. The change itself is simple and direct. The accompanying CHANGELOG.md update is clear and provides users with the necessary information to adapt to this change, including how to opt-out. I have one minor suggestion to improve the formatting in the changelog.

CHANGELOG.md

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

rickeylev · 2025-12-15T00:29:56Z

CI failure:

(00:28:43) ERROR: /workdir/examples/pip_parse/BUILD.bazel:69:8: in env[WHEEL_DATA_CONTENTS] attribute of py_test rule //:pip_parse_test: label '@@rules_python++pip+pypi//s3cmd:data' in $(locations) expression expands to no files. Since this rule was created by the macro 'py_test', the error might have been caused by the macro implementation
(00:28:43) ERROR: /workdir/examples/pip_parse/BUILD.bazel:69:8: Analysis of target '//:pip_parse_test' (config: 5cac5d0) failed

rickeylev · 2025-12-15T00:31:34Z

That failure is a bit strange. It would mean there are literally no files under site-packages?

aignas · 2025-12-15T01:15:16Z

The build query is weird, it seems like a regression to me.

aignas · 2025-12-15T13:19:42Z

Somewhat something that I thought might be the case, we can't just extract a wheel, we need to map certain paths in a particular way:

$ env USE_BAZEL_VERSION=8.5.0 bazel query "deps(@pypi//s3cmd:data)"
@@rules_python++pip+pypi_39_s3cmd//:data
@@rules_python++pip+pypi_39_s3cmd//:data/share/doc/packages/s3cmd/INSTALL.md
@@rules_python++pip+pypi_39_s3cmd//:data/share/doc/packages/s3cmd/LICENSE
@@rules_python++pip+pypi_39_s3cmd//:data/share/doc/packages/s3cmd/NEWS
@@rules_python++pip+pypi_39_s3cmd//:data/share/doc/packages/s3cmd/README.md
@@rules_python++pip+pypi_39_s3cmd//:data/share/man/man1/s3cmd.1

This is what the data contains in the non pipstar case.

aignas · 2025-12-15T13:45:06Z

found it, had it forgotten.

aignas · 2025-12-15T13:46:25Z

@rickeylev, do you wanna do the path remapping at the build time instead of the repo phase? I think that for compatibility reasons we should keep this for now and then we can think about it later on how we can actually extract/link the wheels better.

…star behaviour

aignas · 2025-12-16T14:30:58Z

OK, bugs should have been fixed PTAL.

rickeylev · 2025-12-17T23:11:50Z

yes, lets keep it the same for now, for compatibility.

feat: flip pipstar to be on by default

0054d0f

aignas requested a review from rickeylev as a code owner December 14, 2025 23:35

gemini-code-assist bot reviewed Dec 14, 2025

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Update CHANGELOG.md

5a6f2d0

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

rickeylev approved these changes Dec 15, 2025

View reviewed changes

Merge branch 'main' into chore.flip-pipstar

8869712

wip

389d4f7

aignas requested a review from groodt as a code owner December 15, 2025 13:44

fixup

91961e6

aignas added 5 commits December 15, 2025 22:48

fixup

e1da86f

disable pipstar by default on bazel 7

a127586

do whl extracting only on bazel8 and above

c6a8811

further refactor

4eca3d1

add a marker file to signify the installer of the wheel

2c0b7f9

aignas changed the title ~~feat: flip pipstar to be on by default~~ fix(pipstar): fix whl extraction and flip pipstar=true Dec 16, 2025

aignas added 3 commits December 16, 2025 23:26

revert the internal_config_repo to use the version to set default pip…

0b610c4

…star behaviour

fix the metadata reading

c1a8a2f

Merge branch 'main' into chore.flip-pipstar

4033653

aignas added 3 commits December 17, 2025 00:08

disable pipstar by default on bazel 7

4d8adbb

add a separate flag for extracting wheels

2f3ac0a

it is safe to have the env decide pipstar enabling

8ed1c37

aignas requested a review from rickeylev December 16, 2025 16:12

aignas added 3 commits December 17, 2025 22:53

Merge branch 'main' into chore.flip-pipstar

943df67

fix the extras

e1e7813

Merge branch 'main' into chore.flip-pipstar

508f9b6

rickeylev added this pull request to the merge queue Dec 17, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2025

rickeylev approved these changes Dec 17, 2025

View reviewed changes

rickeylev added this pull request to the merge queue Dec 17, 2025

Merged via the queue into bazel-contrib:main with commit fc2a9f9 Dec 17, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix(pipstar): fix whl extraction and flip pipstar=true #3461

fix(pipstar): fix whl extraction and flip pipstar=true #3461

aignas commented Dec 14, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Dec 14, 2025

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

rickeylev commented Dec 15, 2025

Uh oh!

rickeylev commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 16, 2025

Uh oh!

rickeylev commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

fix(pipstar): fix whl extraction and flip pipstar=true #3461

fix(pipstar): fix whl extraction and flip pipstar=true #3461

Conversation

aignas commented Dec 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot commented Dec 14, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

rickeylev commented Dec 15, 2025

Uh oh!

rickeylev commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 15, 2025

Uh oh!

aignas commented Dec 16, 2025

Uh oh!

rickeylev commented Dec 17, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aignas commented Dec 14, 2025 •

edited

Loading