fix: make python_headers targets compatible with layering checks#3420
Conversation
Previously the headers from this target were available because it dpeends on python_headers_abi3, but that fails downstream layering_checks since the headers weren't direct. Now it re-exports the same headers as that underlying target to satisfy those checks. Inspectable with: ``` bazel cquery --output=starlark --starlark:expr 'providers(target)["@@rules_cc+//cc/private:cc_info.bzl%CcInfo"].compilation_context.direct_public_headers' @rules_python//python/cc:current_py_cc_headers ```
Summary of ChangesHello @keith, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a build system issue where the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the hdrs attribute to the python_headers cc_library target. This makes the headers a direct part of the target's public interface, which, as you noted, is necessary to satisfy some downstream layering checks. The change is correct and addresses the issue. I've added one suggestion to also make the include paths direct for consistency, which would make the python_headers target's interface more explicit.
rickeylev
changed the title
2 participants
Previously the headers from this target were available because it
depends on python_headers_abi3, but that fails downstream
layering_checks since the headers weren't direct. Now it re-exports the
same headers as that underlying target to satisfy those checks.
Inspectable with: