Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Sep 4, 2025

This fixes an issue compiling protobuf on windows due to c++ 17 support.

In particular, it gets the fix in
bazelbuild/rules_cc@c7e5c8c
which adds /std:c++17 for Window builds.

Fixes #3122

@aignas aignas requested a review from rickeylev as a code owner September 4, 2025 13:51
@rickeylev
Copy link
Collaborator

CI gave an error saying gazelle/docs wasn't defined because it's considered deleted. I think the bazelrc update is causing that?

In any case, approved so it can be merged when ready.

@aignas aignas force-pushed the aignas.chore.bump-rules-cc branch from 34bd76e to 36a2123 Compare September 5, 2025 03:04
@aignas aignas enabled auto-merge September 5, 2025 03:06
@aignas
Copy link
Collaborator Author

aignas commented Sep 5, 2025

Somehow the pre-commit hook is not very reliable for the .bazelrc modifications. Maybe we should disable that particular hook?

@aignas aignas added this pull request to the merge queue Sep 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 5, 2025
@aignas aignas added this pull request to the merge queue Sep 5, 2025
Merged via the queue into bazel-contrib:main with commit 277089e Sep 5, 2025
3 of 4 checks passed
@aignas aignas deleted the aignas.chore.bump-rules-cc branch September 5, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bazel CI] Failed cl.exe failed: error executing CppCompile command

2 participants