feat(gazelle): python_proto_naming_convention directive controls py_proto_library naming#3093
Merged
dougthor42 merged 9 commits intobazel-contrib:mainfrom Jul 20, 2025
Conversation
shaldengeki
requested review from
aignas,
dougthor42 and
rickeylev
as code owners
shaldengeki
commented
Jul 15, 2025
dougthor42
reviewed
Jul 15, 2025
Collaborator
dougthor42
left a comment
dougthor42
left a comment
There was a problem hiding this comment.
Nice! I tested this on our monorepo and generated 227 py_proto_library targets. Hot damn!
There are a variety of nits and requests but otherwise this is looking great, thanks!
gazelle/python/testdata/directive_python_proto_naming_convention/README.md
Outdated
Show resolved
Hide resolved
gazelle/python/testdata/directive_python_proto_naming_convention/README.md
Outdated
Show resolved
Hide resolved
gazelle/python/testdata/directive_python_proto_naming_convention/README.md
Outdated
Show resolved
Hide resolved
… violate the naming convention, and adjust behaviour to match
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3081.
This adds support in the Gazelle plugin for controlling how the generated
py_proto_libraryrules are named; support for these was originally added in #3057. We do this via a new Gazelle directive,python_proto_naming_convention, which is similar topython_library_naming_conventionand the like, except it interpolates$proto_name$, which is theproto_libraryrule minus any trailing_proto. We default to$proto_name$_py_pb2.For instance, for a
proto_librarynamedfoo_proto, the default value would generatefoo_py_pb2, aligning with the convention stated in the Bazel docs.