Skip to content

Pass --isolated to pip#232

Merged
brandjon merged 2 commits intobazel-contrib:masterfrom
keith:ks/add-isolated
Sep 6, 2019
Merged

Pass --isolated to pip#232
brandjon merged 2 commits intobazel-contrib:masterfrom
keith:ks/add-isolated

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Sep 5, 2019

This fixes an issue where if you have bad URLs in your ~/.pip/pip.conf,
pip would pick them up and end up failing bazel. This way we make
pip_import more hermetic and ignore user config.

You can reproduce this issue by adding:

[global]
extra-index-url =
    https://foo.com/bar

To your local ~/.pip/pip.conf, and executing a pip_import rule (it fails faster if your URL returns 500s rather than is just unaccessible)

@keith
Pass --isolated to pip
48d2a6a 
This fixes an issue where if you have bad URLs in your ~/.pip/pip.conf,
pip would pick them up and end up failing bazel. This way we make
pip_import more hermetic and ignore user config.
@brandjon
Copy link
Copy Markdown
Contributor

brandjon commented Sep 6, 2019

Thanks for the change. Will merge shortly.

@brandjon brandjon merged commit 54d1cb3 into bazel-contrib:master Sep 6, 2019
@keith
Copy link
Copy Markdown
Member Author

keith commented Sep 6, 2019 via email •
edited
Loading

keith added a commit to keith/rules_python that referenced this pull request Dec 8, 2020
@keith
Pass --isolated to pip wheel invocation
e58b3e3 
This fixes the same issue as
bazel-contrib#232 but in another
place.
@keith keith mentioned this pull request Dec 8, 2020
Merged
keith added a commit to keith/rules_python that referenced this pull request Dec 8, 2020
@keith
Pass --isolated to pip wheel invocation
03c0a39 
This fixes the same issue as
bazel-contrib#232 but in another
place.
thundergolfer pushed a commit that referenced this pull request Jan 5, 2021
@keith
Pass --isolated to pip wheel invocation (#389)
d49c449 
This fixes the same issue as
#232 but in another
place.

Co-authored-by: Jonathon Belotti <[email protected]>
@slsyy
Copy link
Copy Markdown

slsyy commented Apr 7, 2021 •
edited
Loading

Can we do it configurable/revert? It breaks previous behavior. I use PIP_INDEX_URL environment variable to select PyPI repository. I do not see any other option, because depending on build environment I use a different PIP_INDEX_URL, so I can not embed in a requirements.txt. I would be pleased, if you have some workaround to tackle that situation @brandjon @keith

@keith keith deleted the ks/add-isolated branch April 7, 2021 23:18
@keith
Copy link
Copy Markdown
Member Author

keith commented Apr 7, 2021

I think it would be fine to configure if the maintainers are ok with another option for that, you can probably workaround this in the meantime by passing --index-url or --extra-index-url through via extra_pip_args, which would also have the benefit of actually being reproducible across multiple folks machines

@slsyy
Copy link
Copy Markdown

slsyy commented Apr 8, 2021

@keith in my case I also need an user/password pair to use PyPI repo: PIP_INDEX_URL=https://login:[email protected], which need to be unique for each user, and the env variable seems to be the easiest way to generate it by some script

@thundergolfer
Copy link
Copy Markdown

thundergolfer commented Apr 19, 2021

@slsyy I don't have an immediate solution, but could any of these approaches work for you? bazel-contrib/rules_jvm_external#80 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lberki lberki Awaiting requested review from lberki

1 more reviewer

@brandjon brandjon brandjon approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@keith @brandjon @slsyy @thundergolfer @googlebot