Skip to content

README.md, Documentations, and Examples All Out of Date #397

@dayfine

Description

@dayfine

I was trying to switch over from rules_python_external. At first I made a naive change following the current README.md, which didn't work (code compiles but then modules are not imported in runtime). Then I read the instructions again, tried pip3_import, which doesn't exist (under pip.bzl). I then actually read pip.bzl, and tried to do what the comment says, which doesn't work (the code expects requirements.txt under an external directory, i.e. the comment is misleading). Lastly I followed the example and appended // to the requirement file, which felt odd and unnecessary (and realized this was what I was doing with rules_python_external.

Also the repo is not versioned often enough, many of the instruction seems to be for 0.1.0 while the code have moved past it. I ended up simply using HEAD / master.

For the record, the change that I ended up making: a54bf79 (#50)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions