Skip to content

[pypi]: whl_library repository cache is not invalidated when the dependencies change. #2468

@aignas

Description

@aignas

Between 0.31.0 and 0.40.0 there was a bump in the internal wheel_installer deps and the repository cache currently is not invalidated.

The repository files in the cache vs the new value after expunge is called:

packages/MarkupSafe-2.1.1.dist-info/WHEEL	2000-01-01 09:00:00.000000000 +0900
+++ /tmp/diff/input-1/layers-47/app.d/wp_wcm_city/ns/demo/clock/src/server.runfiles/pip_markupsafe/site-packages/MarkupSafe-2.1.1.dist-info/WHEEL	2000-01-01 09:00:00.000000000 +0900
@@ -1,5 +1,5 @@
 Wheel-Version: 1.0
-Generator: bdist_wheel (0.43.0)
+Generator: bdist_wheel (0.41.2)
 Root-Is-Purelib: true
 Tag: py3-none-any

The most likely culprit is the way we include the dependencies which could have regressed or never worked.

The code in question is in https://github.com/bazelbuild/rules_python/blob/096a04fdcd2c3ff29f485d57129a1d838f022867/python/private/pypi/whl_library.bzl#L440

Right now we are only including the BUILD.bazel for the pythonpathconstruction, but it would be better if we included theRECORD` or some other file that changes from version to version. We could also ensure that the version is included somewhere in the BUILD.bazel file.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions