Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.8.0
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.8.1
Choose a head ref
  • 1 commit
  • 3 files changed
  • 2 contributors

Commits on Jan 21, 2026

  1. fix(pipstar): correctly handle complex self deps (#3527) 

    It seems that with the `pipstar` port there was a typo and the initial
tests that we had for Python were insufficient to catch such a
regression.

The second if statement where we loop through packages again had a `req`
instead of `req_` in the `if` statement and the test coverage was not
sufficient.

I have abstracted the if statement into a function to easier spot such
issues and added an extra test to ensure that a regression would be
actually caught. With this the Starlark test suite is now officially
more robust than the Python version.

Fixes #3524

---------

Co-authored-by: Richard Levasseur <[email protected]>
(cherry picked from commit c52aeaa)
    @aignas @rickeylev
    aignas and rickeylev committed Jan 21, 2026
    Configuration menu
    Copy the full SHA
    e7d5362 View commit details
    Browse the repository at this point in the history
Loading