Add a plus sign to the output_groups option#707
Merged
Conversation
thesayyn
approved these changes
Oct 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For people upgrading from earlier versions of rules_oci, it works out better to use
+tarballthantarball. With the docs as currently written, without the plus sign, it will break for anyone using an earlier version of rules_oci. Adding the plus makes it work with either older or newer versions of rules_oci, which is convenient for people who are upgrading incrementally.It's probably a good habit, anyway, to use the plus. When you want an extra output group to a build, you usually don't want to cancel all the output groups you don't know about. You just want to add the one new one that you do care about.