Skip to content

fix: add history entries for tars attribute#654

Merged
thesayyn merged 2 commits into
2.xfrom
add_history_entries
Jul 25, 2024
Merged

fix: add history entries for tars attribute#654
thesayyn merged 2 commits into
2.xfrom
add_history_entries

Conversation

@thesayyn

@thesayyn thesayyn commented Jul 18, 2024

Copy link
Copy Markdown
Collaborator

image-spec says that this field is optional, however some systems like seen in #645 require this field. Also, skipping history entries lead to broken images if the base image already had one.

fixes #645

@thesayyn
thesayyn changed the base branch from main to 2.x July 18, 2024 12:16
@thesayyn

Copy link
Copy Markdown
Collaborator Author

This partially fixes #438 too.

@thesayyn
thesayyn force-pushed the add_history_entries branch 2 times, most recently from ad5d50d to e422780 Compare July 18, 2024 14:35
@thesayyn
thesayyn requested a review from alexeagle July 18, 2024 14:36
Comment thread oci/private/image.bzl
@thesayyn
thesayyn force-pushed the add_history_entries branch from e422780 to ee081b5 Compare July 25, 2024 17:37
@thesayyn
thesayyn merged commit 94be214 into 2.x Jul 25, 2024
@thesayyn
thesayyn deleted the add_history_entries branch July 25, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.0.0beta1: regression: cmd inherited from base image should be cleared when setting entrypoint

2 participants